Age Message
8 years 5 months Put code to construct unique path into new utlity function uniquePath()

Two almost identical versions existed of this code.

I generalized the code by taking out the knowledge of sections.
No other uses of this code are planned, but it is easier to review in
isolation now.
Commit 1b54483f21b359721a276b0a74c92deb4829c533, by Maarten ter Huurne
8 years 5 months Put code for moving links to a different section into Menu class

This is another step in bringing the management of the links on the
file system into a single location (the Menu class).

Fixes were applied as well. For example a directory for the new section
is now created if it did not exist yet.
Commit 8e76dffc70b34fe36afd875363c6f4dd6919b72e, by Maarten ter Huurne
8 years 5 months Fix bug in section directory creation method

The child directory (the one bearing the section name) was never
created; instead the parent directory (named "sections") was created
twice.
Commit 73ceffa51d3450d2d20ce933e7fc6da187e09fc8, by Maarten ter Huurne
8 years 5 months Make sure inserting a new section doesn't change the selected section
Commit b6fcf0f69db8fa2de1926cf39dbb4cee3408c2c0, by Maarten ter Huurne
8 years 5 months Changed LinkApp::renameFile() to setFile()

The original method name suggested it might rename the file on disk,
which it does not.
Commit 49bbf3a4f6aea366009f0bca27ab0ded34e0bff4, by Maarten ter Huurne
8 years 5 months Add "/compile" to .gitignore

This file is put there by one of the GNU autotools.
Commit 10429af6c9a0199d74fd5b541183c7d34dc4a84f, by Maarten ter Huurne
8 years 5 months Moved section directory delete code to Menu class

It is better to have all the file handling code for menu entry files
in the same place.
Commit f17fae79b6840c930d19bb5d88898f66b4694e60, by Maarten ter Huurne
8 years 5 months Only allow empty sections to be deleted

Since not all links can be deleted, an action that deletes a section
and all the links it contains cannot be reliably implemented.
Therefore, the action will only be offered if all links have already
been deleted (or were never added in the first place).
Commit c2759f1263fef5da265db7c1af65b5c767cd4860, by Maarten ter Huurne
8 years 5 months Removed "gp2x.h" header

None of the definitions in it were used anymore.
Commit aeb9c12f5d4734244b1c9a060927e6e727677db0, by Maarten ter Huurne
8 years 5 months Set a window title

This is useful when testing on PC.
Commit aeb9b0b2df6f45989d1a47a0151a79b1aefdf657, by Maarten ter Huurne
8 years 5 months Declare "dirp" and "dptr" pointers just before they're needed
Commit 4159e6925beb9b2f2732b2ac7dce7eae9d75de0b, by Maarten ter Huurne
8 years 5 months Cleaned up code that loads a manual from an OPK file

Most of it is for readability only, but there is also a leak that was
plugged: opk_close() is now called if extraction fails.
Commit 510d67359c9d79c2958414f2e959ff8baeab0dbb, by Maarten ter Huurne
8 years 5 months Gave Layer class a protected constructor
Commit 00d3c3b57008bddf8770c51271db9d766acaf854, by Maarten ter Huurne
8 years 5 months Removed unused MMSP2ADC struct definition

A leftover from platform code that was removed long ago?
Commit 519387e38cc3de0d47ec69361c705449304f37fa, by Maarten ter Huurne
8 years 5 months Fixed formatting string type mismatches

The "%zd" conversion specification seems to produce no warnings on both
32-bit and 64-bit systems.
Commit 9394a95a6c43f853ce615706b8ff30992489d6cc, by Maarten ter Huurne
8 years 5 months Removed unused methods in LinkApp class
Commit 90a8d90e49b6905312eda3501a1b8af8960c3307, by Maarten ter Huurne
8 years 5 months Suppress Clang analyzer warnings about dead assignments

The last assignment in the series is indeed dead, but for consistency
I want to keep it around.
Commit 7b10f9448bb9965e94f9a37a59f0999e9c51e68f, by Maarten ter Huurne
8 years 5 months Quit GMenu2X when window is closed in main screen

This helps when testing on PC.

I didn't bother to implement the same functionality for all dialog
event loops, since that would be a lot of extra work and not necessary
for the scenario that I need it for: clean exit when running under
Valgrind.
Commit cb1b26e5e67d79ca9d03e85db06ec6c2e5b3557a, by Maarten ter Huurne
8 years 5 months Removed the "Rename section" option

This option is not compatible with section names being provided by
other sources than user-created links. Examples of other sources are
built-in action links, links installed by a distro in a read-only
directory and metadata from OPK files.
Commit ef6d378c5e401954308260d1fe3a53429fa66f4c, by Maarten ter Huurne
8 years 11 months Remove all touch-screen-related code

It didn't work anymore, at all. Touchscreen polling occurred only
*after* waiting for a button had completed. So the touchscreen events,
if any, would be ignored until the user had pressed a button, possibly
firing off another action with that button press and forwarding the
touchscreen event to the next interface that got brought up as a
result.

Reusing this code and fixing it would require far more work than
rewriting everything anew with touchscreen devices in mind from the
beginning.

MtH: Resolved conflicts, mainly from the GMenu2X pointer to reference
change I did on 2015-04-21.
Commit 2a2634b3640286bf05fa5158e5f71ba1d2490aea, by Nebuleon Fumika
8 years 5 months Removed include of <ini.h>

No functions from libini are used, so this line was probably left there
by accident.
Commit 16aa3dd999840035e99f1449381c046a579813ac, by Maarten ter Huurne
8 years 5 months Keep track of Link objects using unique_ptr

This ensures the memory is freed when the pointers are removed. While
there was an explicit delete loop in the destructor, memory leaks could
occur when links were removed from the menu.
Commit 7eb377a8578d44365073179c54e6ee155cb73f33, by Maarten ter Huurne
8 years 5 months Use const references to strings in Menu method arguments

This avoids unnecessary copying.

Removed sectionName argument to addLink(), since its only caller didn't
provide a value for it, meaning it always defaulted.
Commit aa45ed9a74ba5818a8000a06a0ddf61c2a2f7c32, by Maarten ter Huurne
8 years 5 months Keep list of section names sorted at all times

Keeping it sorted when sections are inserted after startup improves the
user experience and if we have code for that already, we might as well
use it during startup too.
Commit 9ca019ef513cdaaea64a283dd8f12c9c57787627, by Maarten ter Huurne
8 years 5 months Create sections for built-in action links if necessary

Previously, the built-in actions would only be added if their
respective sections already existed.

This also works around the fact that Menu::paint() crashes if there
are no sections present.
Commit fad68bfb6ee5d5407e531cd4f23622e8c71f44d1, by Maarten ter Huurne

Branches:
install_locations
master
opkrun
packages



interactive