Date:2011-07-07 01:26:12 (9 years 6 days ago)
Author:Werner Almesberger
Commit:1b9d72f56fae0d149c5307a3f9f38f3b3d410b87
Message:atusb: updated to do list and added missing \n to dev_info

Files: drivers/spi/atusb.c (4 diffs)

Change Details

drivers/spi/atusb.c
1111 */
1212
1313/*
14 * - Implement buffer and sram read write
15 * - Implement IRQ handling
14 * - implement more robust interrupt synchronization
15 * - check URB killing in atusb_disconnect for races
16 * - switch from bulk to interrupt endpoint
17 * - implement buffer read without extra copy
18 * - decrease debug chatter
19 * - harmonize indentation style
20 * - mv atusb.c ../ieee802.15.4/spi_atusb.c, or maybe atrf_atusb.c or such
21 * - check module load/unload
1622 */
1723
1824#include <linux/kernel.h>
...... 
418424    if (!retval)
419425        return 0;
420426
421    dev_err(&dev->dev, "failed submitting bulk urb, error %d", retval);
427    dev_err(&dev->dev, "failed submitting bulk urb, error %d\n", retval);
422428    retval = retval == -ENOMEM ? retval : -EIO;
423429
424430    usb_free_urb(urb);
...... 
493499        atusb->buffer, 3, 1000);
494500    if (retval < 0) {
495501        dev_info(&dev->dev,
496            "failed submitting urb for ATUSB_ID, error %d", retval);
502            "failed submitting urb for ATUSB_ID, error %d\n", retval);
497503        return retval == -ENOMEM ? retval : -EIO;
498504    }
499505
...... 
520526        build, ATUSB_BUILD_SIZE, 1000);
521527    if (retval < 0) {
522528        dev_info(&dev->dev,
523            "failed submitting urb for ATUSB_BUILD, error %d", retval);
529            "failed submitting urb for ATUSB_BUILD, error %d\n",
530            retval);
524531        return retval == -ENOMEM ? retval : -EIO;
525532    }
526533

Archive Download the corresponding diff file



interactive