Date:2011-07-06 23:53:03 (9 years 2 months ago)
Author:Werner Almesberger
Commit:4c977e4dfb6e95caec9cdebe1cac7b87b1e3d40b
Message:atusb: moved firmware version info before AT86RF230 driver bringup

This makes the sequence of messages a bit more logical and also makes
sure atusb_probe succeeds on successful spi_new_device.

Signed-off-by: Werner Almesberger <werner@almesberger.net>
Files: drivers/spi/atusb.c (2 diffs)

Change Details

drivers/spi/atusb.c
590590    tasklet_init(&atusb->task, atusb_tasklet, (unsigned long) atusb);
591591    atusb_arm_interrupt(atusb);
592592
593    if (atusb_get_and_show_revision(atusb) < 0)
594        goto err_master;
595    if (atusb_get_and_show_build(atusb) < 0)
596        goto err_master;
597
593598    atusb->spi = spi_new_device(master, &board_info);
594599    if (!atusb->spi) {
595600        dev_info(&udev->dev, "can't create new device for %s\n",
...... 
600605    dev_info(&atusb->spi->dev,
601606        "ATUSB ready for mischief (IRQ %d)\n", board_info.irq);
602607
603    if (atusb_get_and_show_revision(atusb) < 0)
604        goto err_master;
605    if (atusb_get_and_show_build(atusb) < 0)
606        goto err_master;
607
608608    return 0;
609609
610610err_master:

Archive Download the corresponding diff file



interactive