Date:2010-05-20 02:22:19 (10 years 4 months ago)
Author:Maarten ter Huurne
Commit:4f54f6cf5d3089dac3e48e936abc18663c0dc581
Message:jz4740-slcd-fb: Removed obsolete TODOs.

Files: drivers/video/jz4740_slcd_fb.c (2 diffs)

Change Details

drivers/video/jz4740_slcd_fb.c
434434    jzfb_disable_dma(jzfb);
435435    jzfb->panel->enable(jzfb);
436436
437    // TODO: SLCD equivalents:
438#if 0
439    writel(0, jzfb->base + JZ_REG_LCD_STATE);
440
441    writel(jzfb->framedesc->next, jzfb->base + JZ_REG_LCD_DA0);
442#endif
443
444437    ctrl = readl(jzfb->base + JZ_REG_LCD_CTRL);
445438    ctrl |= JZ_LCD_CTRL_ENABLE;
446439    ctrl &= ~JZ_LCD_CTRL_DISABLE;
...... 
739732
740733    jzfb_free_gpio_pins(jzfb);
741734
742    // TODO: Which part of the code guarantees that a DMA transfer is
743    // not still in progress?
744    // * jz4740_dma_free() does not
745    // * FB_BLANK_POWERDOWN should, I think; check it
746735    jz4740_dma_free(jzfb->dma);
747736
748737    iounmap(jzfb->base);

Archive Download the corresponding diff file



interactive