Date:2010-05-11 07:54:56 (13 years 7 months ago)
Author:Jonathan Nieder
Commit:e140411424701e49ab9252a70e62c8a2e120cd06
Message:unset executable bit on firmware image

This firmware is not meant to be executed on the host machine, so
unset its executable bit. Noticed by lintian.

While at it, teach stage1 builds to recover from interrupted builds by
ensuring *stage1.bin are not present until all of the relevant
commands have been run.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Files: usbboot/xburst_stage1/Makefile (1 diff)
usbboot/xburst_stage2/Makefile (1 diff)
xbboot/target-stage1/Makefile (1 diff)

Change Details

usbboot/xburst_stage1/Makefile
2323all: xburst_stage1.bin
2424
2525xburst_stage1.bin: xburst_stage1.elf
26    $(CROSS_COMPILE)objcopy -O binary $< $@
26    $(CROSS_COMPILE)objcopy -O binary $< $@+
2727    $(CROSS_COMPILE)objdump -D $< > xburst_stage1.dump
2828    $(CROSS_COMPILE)objdump -h $< > xburst_stage1.map
2929    $(CROSS_COMPILE)nm -n $< > System.map
30    chmod -x $@+
31    mv -f $@+ $@
3032
3133xburst_stage1.elf: $(OBJS)
3234    $(CROSS_COMPILE)ld $(LDFLAGS) $(OBJS) -o $@
usbboot/xburst_stage2/Makefile
3737
3838all: xburst_stage2.elf
3939    $(OBJCOPY) -O binary xburst_stage2.elf xburst_stage2.bin
40    chmod -x xburst_stage2.bin
4041    $(OBJDUMP) -D xburst_stage2.elf > xburst_stage2.dump
4142    $(NM) xburst_stage2.elf | sort > xburst_stage2.sym
4243    $(OBJDUMP) -h xburst_stage2.elf > xburst_stage2.map
xbboot/target-stage1/Makefile
2121all: stage1.bin
2222
2323stage1.bin: stage1.elf
24    $(CROSS_COMPILE)objcopy -O binary $< $@
24    $(CROSS_COMPILE)objcopy -O binary $< $@+
2525    $(CROSS_COMPILE)objdump -D $< > stage1.dump
2626    $(CROSS_COMPILE)objdump -h $< > stage1.map
2727    $(CROSS_COMPILE)nm -n $< > System.map
28    chmod -x $@+
29    mv -f $@+ $@
2830
2931stage1.elf: $(OBJS)
3032    $(CROSS_COMPILE)ld $(LDFLAGS) $(OBJS) -o $@

Archive Download the corresponding diff file



interactive